Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

For node, if only moment-timezone is installed, and error is thrown that moment isn't found #48

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

For node, if only moment-timezone is installed, and error is thrown that moment isn't found #48

wants to merge 4 commits into from

Conversation

brandongoode
Copy link

No description provided.

@c-trimm
Copy link
Owner

c-trimm commented Oct 18, 2016

Instead of try/catch blocks with empty catches, could we use something like require.defined() to see if either of those modules exists before trying to load them?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brandongoode @c-trimm